gh-144325: Improve error messages for {}-style formatters for int, float, str, and complex
#144326
+328
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
yuanx749
reviewed
Jan 31, 2026
|
|
||
| def test_invalid_specifier_type_error_message(self): | ||
| for value in [12j, 12, 12.0, "12"]: | ||
| for bad_spec, repr in [ |
Contributor
There was a problem hiding this comment.
Nit: repr is a built-in.
Suggested change
| for bad_spec, repr in [ | |
| for bad_spec, repr_str in [ |
| ]: | ||
| with self.subTest(value=value, bad_spec=bad_spec): | ||
| err = re.escape("Unknown format code " | ||
| f"{repr} for object of type " |
Contributor
There was a problem hiding this comment.
Suggested change
| f"{repr} for object of type " | |
| f"{repr_str} for object of type " |
| if (actual_format_spec != NULL) { | ||
| PyErr_Format(PyExc_ValueError, | ||
| "Invalid format specifier '%U' for object of type '%.200s'", | ||
| "Invalid format specifier %R for object of type '%.200s'", |
Member
There was a problem hiding this comment.
While we are here, we can use %T.
| } | ||
| } | ||
|
|
||
| if (end-pos) { |
Member
There was a problem hiding this comment.
There are already some checks above. I think that it is better to modify them. Your code emits weird error message for formats ,10, or _10_.
| } | ||
| else if (Py_UNICODE_ISPRINTABLE(conversion)) { | ||
| PyErr_Format(PyExc_ValueError, | ||
| "Unknown conversion specifier '%c' (U+%04X)", |
Member
There was a problem hiding this comment.
Such code is now repeated 3 times. Maybe add a helper function? For example, a function that formats "'%c' (U+%04X)" (with special cases).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first implementation of my suggested changes in the issue.
Some proposals are open for discussion, though the PR already includes test cases.
I would appreciate any feedback or suggestions on these proposed changes.
{}style formatters for int, float, str, and complex #144325